chore: Remove Dafny trigger warnings #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes Dafny warnings around `forall` statments lacking a `{trigger}`
| @@ -209,7 +209,7 @@ module {:options "-functionSyntax:4"} DivMod { | |||
| ensures forall a: int, b: int, d: int, R: int {:trigger d * ((a + b) / d) - R, d*(a/d) + d*(b/d)} | |||
| :: 0 < d && R == a%d + b%d - (a+b)%d ==> d*((a+b)/d) - R == d*(a/d) + d*(b/d) | |||
| { | |||
| forall (a: int, b: int, d: int, R: int {:trigger true} | 0< d && R == a%d + b%d - (a+b)%d) | |||
| forall (a: int, b: int, d: int, R: int {:trigger d * ((a + b) / d) - R, d*(a/d) + d*(b/d)} | 0< d && R == a%d + b%d - (a+b)%d) | |||
There was a problem hiding this comment.
I think you can't use interpreted functions, like any of the arithmetic or logical operators, in a trigger. Sorry that there is no automatic feedback on this, or even good documentation. And to be honest I'm not sure what the right trigger for this forall would be. @MikaelMayer @atomb ?
There was a problem hiding this comment.
You can run Dafny and it will give you some help, but also {:nowarn} works in newer versions of Dafny, and that gets me what I want!
There was a problem hiding this comment.
Please use {:nowarn} everywhere then. These triggers are not valid triggers because they map to builtin operators that do not work with pattern matching.
robin-aws
approved these changes
Oct 4, 2024
ssomayyajula
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Dafny warnings around
forallstatments lacking a{trigger}By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.